Repository navigation
docs(releasing): document that publish.yml only fires on three-part v tags - #76
Merged
Merged
Conversation
The v*.*.* trigger needs two dots after the v, so a tag such as v1.0 never starts the workflow even when it equals v + __version__. The doc claimed every mismatched v-prefixed tag fails the build loudly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against the diff and command output):
Finding fixed during review:
Judgment call, raised for a maintainer and not changed:
This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RELEASING.mdsaid that av-prefixed tag whose version does not match__version__"fails the build before anything is published". That only holds for tags thepublish.ymltrigger matches. The trigger is the globv*.*.*, which needs two dots after thev, so a tag such asv1.0never starts the workflow at all. That is true even when the tag equalsv+__version__, so following the documented rule exactly with a two-part version produces a silent no-op instead of a release.vprefix; fewer than three parts) together. It also notes that the existingv0.1tag on the remote has that shape. No claim is made about whetherv0.1was ever meant to publish: it may predate the workflow.publish.ymlis not touched, since workflow files are excluded from autonomous change. Whether the trigger should be broadened is left to the maintainer decision already pending in release: version tags are pushed without the 'v' prefix publish.yml requires, so no release has ever been published #34.No tracking issue: the gap was found during a Stage A documentation accuracy sweep.
Evidence
publish.ymlline 10:- "v*.*.*".git ls-remote --tags origin→0.2.0,0.3.0.dev20260808,v0.1.gh run list --workflow publish.yml→ no runs.*-matches-dots semantics as GitHub's tag filter for slash-free names):v0.1False,v1.0False,v0.2.0True,v0.3.0.dev20260808True,0.2.0False.Test plan
python3 -m pytest -q src/test/python: 157 passed (headless, viaconftest.py's dummy SDL drivers). No code or test changed. The run only shows that the tree is unaffected.publish.yml's trigger and the remote tag list above.Skipped issues
.github/workflows/, which is excluded from autonomous change.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson